search

tektoncd / community

Community documentation for the Tekton project
https://tekton.dev
Apache License 2.0
360 stars 221 forks source link

Update usage of StepResults with StepActions #1107

Closed chitrangpatel closed 8 months ago

chitrangpatel commented 8 months ago

Prior to this, the TEP did not go into details of the use of StepResults in inlined step. For consistency with StepActions, this PR includes the use of StepResults for inlined Steps as well.

This is a PR following consensus in the API WG on Nov 20, 2023.

/kind tep

chitrangpatel commented 8 months ago

/assign @wlynch @afrittoli @vdemeester @dibyom

chitrangpatel commented 8 months ago

Wonder if there is a section in the TEP to include all the api changes? Since results, params to step are also new introduced api fields. I think we need to include them in the design

We show it through the examples. I can do that but lets do it in another TEP since this is blocking an implementation PR.

Yongxuanzhang commented 8 months ago

Wonder if there is a section in the TEP to include all the api changes? Since results, params to step are also new introduced api fields. I think we need to include them in the design

We show it through the examples. I can do that but lets do it in another TEP since this is blocking an implementation PR.

Thanks!

tekton-robot commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop, Yongxuanzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[teps/OWNERS](https://github.com/tektoncd/community/blob/main/teps/OWNERS)~~ [jerop] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment