Closed AlanGreene closed 4 months ago
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
/kind documentation /test all
Some additional testing required to ensure compatibility between this new config option and the existing tenant namespaces behaviour, and no other unexpected side effects.
Thanks Brian, updated those strings π
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: briangleeson
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Changes
Resolves https://github.com/tektoncd/dashboard/issues/3297
When the Dashboard deployment's
--default-namespace
arg is set, this configures teh default namespace selected when loading the application instead of 'All Namespaces' being selected.This behaviour will only be triggered when the Dashboard is loaded with no path on the URL, i.e. only for the root (which automatically redirects to the About page).
The reason for this limitation is that handling the default namespace configuration as part of the normal namespace processing would break the ability to select 'All Namespaces' from the namespace filter dropdown, as well as causing issues with URL consistency. It would also be impossible to differentiate between a user attempting to visit a namespaced page (e.g. PipelineRuns) with 'All Namespaces' selected, vs. with no selection which would be expected to use the default namespace instead.
/kind feature
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes