tektoncd / dashboard

A dashboard for Tekton!
Apache License 2.0
863 stars 258 forks source link

Add support for displayName from childReferences #3345

Closed AlanGreene closed 4 months ago

AlanGreene commented 4 months ago

Changes

https://github.com/tektoncd/dashboard/issues/2410 Depends on https://github.com/tektoncd/pipeline/pull/7683

Update utils to support pulling the pipeline task displayName from the run's status.childReferences. This adds support for dynamic matrix display names, and provides a consistent location to retrieve the resolve display name value after param substitution etc. has taken place.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Release Notes

Add support for matrix task display names. When a `displayName` is set on a matrix task, the Dashboard will now retrieve that value from the PipelineRun status if present and display it in the task tree instead of the pipeline task name which would be the same for all instances of that matrix task. This makes it easier for users to differentiate between instances of the task without having to inspect the params or logs.

This feature requires Pipelines v0.58.0 or newer.
tekton-robot commented 4 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

AlanGreene commented 4 months ago

Tentatively targetting Dashboard v0.45 if https://github.com/tektoncd/pipeline/pull/7683 is included in Pipelines v0.58 next week and we have time to fully test it.

AlanGreene commented 4 months ago

/kind feature

AlanGreene commented 4 months ago

Tested with Pipelines nightly release v20240319-81ea62d876

Before: image

After: image

tekton-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briangleeson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/dashboard/blob/main/OWNERS)~~ [briangleeson] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment