tektoncd / dashboard

A dashboard for Tekton!
Apache License 2.0
863 stars 258 forks source link

Ensure getInstallProperties always returns a value #3363

Closed AlanGreene closed 3 months ago

AlanGreene commented 3 months ago

Changes

With React Query 4+ a query function must always either return a value or throw an error. The install properties getter was previously returning undefined which meant React Query 3 would keep using the placeholder data. That's no longer the case so we have to return the default in this case.

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Release Notes

NONE
AlanGreene commented 3 months ago

/hold

tekton-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briangleeson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/dashboard/blob/main/OWNERS)~~ [briangleeson] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
AlanGreene commented 3 months ago

/hold cancel