tektoncd / dashboard

A dashboard for Tekton!
Apache License 2.0
863 stars 258 forks source link

Adopt CSS logical properties #3406

Closed AlanGreene closed 2 months ago

AlanGreene commented 2 months ago

Changes

Prepare for Carbon 11 upgrade, adopt CSS logical properties for consistency and to take advantage of some of the new auto-layout features.

Logical properties aren't supported in media queries yet so there are still some uses of min-width remaining for now.

Similarly, the logical property replacements for overflow-x and overflow-y are currently only supported in Firefox, so we keep the existing properties for now and can implement a workaround to honour writing direction etc. if needed.

Also update some variables and other identifiers in code to use the start / end naming for consistency. Some functions which are part of component APIs keep their original naming for now.

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Release Notes

NONE
tekton-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briangleeson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/dashboard/blob/main/OWNERS)~~ [briangleeson] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment