tektoncd / dashboard

A dashboard for Tekton!
Apache License 2.0
863 stars 258 forks source link

Update react-router-dom-v5-compat to latest version #3409

Closed AlanGreene closed 1 month ago

AlanGreene commented 2 months ago

Changes

https://github.com/tektoncd/dashboard/issues/2452

Related to https://github.com/tektoncd/dashboard/pull/2650 This is a prereq to updating react-router-dom to v6, which in turn is a prereq to https://github.com/tektoncd/dashboard/issues/3381.

Add workaround for breaking change introduced in 6.5.0 which removed support for query params in paths as part of adding support for optional route segments.

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Release Notes

NONE
tekton-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briangleeson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/dashboard/blob/main/OWNERS)~~ [briangleeson] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment