tektoncd / dashboard

A dashboard for Tekton!
Apache License 2.0
868 stars 264 forks source link

Simplify API utils for constructing URLs #3421

Closed AlanGreene closed 4 months ago

AlanGreene commented 4 months ago

Changes

Related to https://github.com/tektoncd/dashboard/issues/2452 and https://github.com/tektoncd/dashboard/issues/3381

There's no longer a need for multiple utils to build Kube API URLs. This is an artifact of an earlier approach which is no longer used.

Combine the various URL builders into a single util and replace usage as appropriate.

getTektonAPI will be removed in a future change.

This simplification will be core to the planned updates for React Router 6, providing a single common approach to handling all Kube resources in the app.

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Release Notes

NONE
tekton-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briangleeson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/dashboard/blob/main/OWNERS)~~ [briangleeson] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment