tektoncd / dashboard

A dashboard for Tekton!
Apache License 2.0
868 stars 264 forks source link

Update to React Router 6 #3423

Closed AlanGreene closed 4 months ago

AlanGreene commented 4 months ago

Changes

https://github.com/tektoncd/dashboard/issues/2452

Follow the remaining steps in the migration guide to replace the compat layer with actual use of React Router 6 directly. This includes:

While this does update us to React Router 6 there is still more to be done to take advantage of the new features, such as the handle prop on Routes to avoid the need for our custom NamespacedRoute component etc. This will be tackled in the near future and will dramatically simplify the code, allowing for a more uniform approach to handling Kube resources without the current overhead of custom containers per kind etc.

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Release Notes

NONE
tekton-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briangleeson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/dashboard/blob/main/OWNERS)~~ [briangleeson] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment