Follow the remaining steps in the migration guide to replace the compat layer with actual use of React Router 6 directly. This includes:
move Route children into the element prop
refactor use of the Link's component prop to the new approach
update tests to avoid relying on history
and more
While this does update us to React Router 6 there is still more to be done to take advantage of the new features, such as the handle prop on Routes to avoid the need for our custom NamespacedRoute component etc. This will be tackled in the near future and will dramatically simplify the code, allowing for a more uniform approach to handling Kube resources without the current overhead of custom containers per kind etc.
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
[ ] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[ ] Release notes block below has been updated with any user facing changes (new features, significant UI changes, API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
[ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release
Needs approval from an approver in each of these files:
- ~~[OWNERS](https://github.com/tektoncd/dashboard/blob/main/OWNERS)~~ [briangleeson]
Approvers can indicate their approval by writing `/approve` in a comment
Approvers can cancel approval by writing `/approve cancel` in a comment
Changes
https://github.com/tektoncd/dashboard/issues/2452
Follow the remaining steps in the migration guide to replace the compat layer with actual use of React Router 6 directly. This includes:
Route
children into theelement
propLink
'scomponent
prop to the new approachhistory
While this does update us to React Router 6 there is still more to be done to take advantage of the new features, such as the
handle
prop onRoute
s to avoid the need for our customNamespacedRoute
component etc. This will be tackled in the near future and will dramatically simplify the code, allowing for a more uniform approach to handling Kube resources without the current overhead of custom containers per kind etc./kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes