tektoncd / dashboard

A dashboard for Tekton!
Apache License 2.0
863 stars 258 forks source link

Refactor Header and SideNav for easier packaging as a static route #3440

Closed AlanGreene closed 1 month ago

AlanGreene commented 1 month ago

Changes

https://github.com/tektoncd/dashboard/issues/2452

Refactor the Header and SideNav components so that they can be more easily consumed as part of a statically defined route using the new React Router data APIs. This means the header and logout button are no longer pure UI components, and are moved to the containers folder instead, so they can use Dashboard-specific APIs and data as needed. These components are quite specific to the Dashboard application anyway so didn't really make sense as pure UI components in the first place.

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Release Notes

NONE
AlanGreene commented 1 month ago

/test all

tekton-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briangleeson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/dashboard/blob/main/OWNERS)~~ [briangleeson] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment