tektoncd / dashboard

A dashboard for Tekton!
Apache License 2.0
863 stars 258 forks source link

Fix tests that were intermittently failing in CI #3441

Closed AlanGreene closed 1 month ago

AlanGreene commented 1 month ago

Changes

These tests have been failing intermittently in CI for about a year now but until now had been unable to reproduce locally. For some unknown reason (suspect dependency updates) they became consistently reproducible locally this week, but were consistently passing in CI :shrug:

Ensure all expected API calls are mocked for the error cases in the affected tests so that they behave predictably.

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Release Notes

NONE
tekton-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briangleeson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/dashboard/blob/main/OWNERS)~~ [briangleeson] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment