tektoncd / dashboard

A dashboard for Tekton!
Apache License 2.0
863 stars 258 forks source link

Use react router's route handle functionality to remove duplicate containers #3481

Closed AlanGreene closed 1 day ago

AlanGreene commented 3 days ago

Changes

https://github.com/tektoncd/dashboard/issues/2452

Configure the resource GVK on the relevant routes to enable use of a common container for most resource list pages. This also means that a number of custom hooks are no longer required.

Ensure extensions work as expected in this new setup, correctly handling the namespace dropdown behaviour depending on whether the extension is for namespace-scoped or cluster-scoped resources.

Rename params in paths to use consistent naming, i.e. name should always be used for the resource name to allow for common code to process this centrally without the need for resource-specific handling.

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Release Notes

NONE
tekton-robot commented 1 day ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briangleeson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/dashboard/blob/main/OWNERS)~~ [briangleeson] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
AlanGreene commented 14 hours ago

This resolves most of the blockers for https://github.com/tektoncd/dashboard/issues/3381