search

tektoncd / dashboard

A dashboard for Tekton!
Apache License 2.0
868 stars 264 forks source link

Configuration of Tekton Dashboard service url content path #3607

Closed Romanecek closed 2 weeks ago

Romanecek commented 2 weeks ago

This is a solution proposal for the feature request described in https://github.com/tektoncd/dashboard/issues/3606

Thank you for your feedback

linux-foundation-easycla[bot] commented 2 weeks ago

CLA Signed


The committers listed above are authorized under a signed CLA.

tekton-robot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign lyndseybu after the PR has been reviewed. You can assign the PR to them by writing /assign @lyndseybu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/tektoncd/dashboard/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tekton-robot commented 2 weeks ago

Hi @Romanecek. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
AlanGreene commented 2 weeks ago

Thanks for the PR @Romanecek. As mentioned in https://github.com/tektoncd/dashboard/issues/3606#issuecomment-2352660640 there was actually a bug in the client affecting the external logs API.

The Dashboard client automatically detects its context root and uses this as a prefix for all API requests. However, the external logs were missed so they would always go to the domain root instead.

https://github.com/tektoncd/dashboard/pull/3614 addresses this and once merged I'll spin a nightly release so you can verify it resolves your issue.

The fix will be included in v0.51.0 which is due in ~1-2 weeks.

Closing this.