tektoncd / dashboard

A dashboard for Tekton!
Apache License 2.0
874 stars 265 forks source link

Ensure common styles for app theme don't leak to consumers #3639

Closed AlanGreene closed 1 month ago

AlanGreene commented 1 month ago

Changes

Scope the light theme to ensure it only affects the Dashboard app, rather than applying to all consumers who haven't set the tkn--theme-dark class on some wrapper. Consumers may choose to use a different theme, e.g. white as their light theme so we need to make sure this is respected.

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Release Notes

NONE
tekton-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briangleeson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/dashboard/blob/main/OWNERS)~~ [briangleeson] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment