tektoncd / dashboard

A dashboard for Tekton!
Apache License 2.0
863 stars 258 forks source link

Front End Development for Triggers UI #937

Open kimholmes opened 4 years ago

kimholmes commented 4 years ago

This issue provides front end development specifications to build the Triggers UI of the dashboard. These designs are based on UX iterations between the design and development teams and are based on previous design specs located under this Epic:

https://github.com/tektoncd/dashboard/issues/675 The design contact is @ carrenelloyd

TriggerTemplate_Details TriggerTemplate_DetailsSpec EventListener_Detail EventListener_DetailSpec

carrenelloyd commented 4 years ago

Please ping me on Slack with any questions. Slack: @carrie

kimholmes commented 4 years ago

@carlos-logro @AlanGreene

ncskier commented 4 years ago

I just noticed that the Triggers | YAML toggle menu should probably be a Triggers header. Instead, the toggle button should be at the top of the page, and it should read Details | YAML to match the toggles we have in the rest of the pages: Screen Shot 2020-02-04 at 11 08 08 AM

The current layout will look weird when switching to the YAML view, because the entire page becomes YAML: Screen Shot 2020-02-04 at 11 10 43 AM

kimholmes commented 4 years ago

@ncskier Just had a conversation with Carrie, the viz designer and she reminded me that we did decide to move those tabs down. The reasoning behind it was that, if we have a Details tab up top, it will be very sparse. So, we decided we didn't need a Details tab and that resulted in moving the tabs below the Details content.

carrenelloyd commented 4 years ago
  1. Added Details subheader below Tabs
  2. $productive-heading-02
  3. 24 spacing token above and below the Details text

image

image

tekton-robot commented 3 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with /close.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

tekton-robot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close.

/lifecycle stale

Send feedback to tektoncd/plumbing.

tekton-robot commented 3 years ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

tekton-robot commented 3 years ago

@tekton-robot: Closing this issue.

In response to [this](https://github.com/tektoncd/dashboard/issues/937#issuecomment-673397454): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >/close > >Send feedback to [tektoncd/plumbing](https://github.com/tektoncd/plumbing). Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
AlanGreene commented 3 years ago

/remove-lifecycle rotten /reopen

tekton-robot commented 3 years ago

@AlanGreene: Reopened this issue.

In response to [this](https://github.com/tektoncd/dashboard/issues/937#issuecomment-673404751): >/remove-lifecycle rotten >/reopen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
AlanGreene commented 3 years ago

/remove-lifecycle stale

AlanGreene commented 3 years ago

We should also consider how a user will navigate between Triggers resources and the resulting Pipelines resources. This has come up a number of times, most recently in https://tektoncd.slack.com/archives/CHTHGRQBC/p1602508229019000. Although that question was initially focused on the Pipeline visualisation it makes sense to consider how it would affect navigation and the presentation of the Triggers resources too.

tekton-robot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale with a justification. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

AlanGreene commented 3 years ago

/lifecycle frozen