Closed fische closed 1 year ago
Hi @fische. Thanks for your PR.
I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
@fische Thank you for this! I hope to have this functionality in tree eventually, but in the meanwhile it'd be great to have this controller in shape, much appreciated!
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: afrittoli
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Changes
The Pipelines-in-Pipelines controller is currently still depending on github.com/tektoncd/pipeline v0.20.0 and only works with the old Runs resources. This means it basically can't be used with recent versions of Tekton, as they use the new CustomRun resource.
This PR addresses this, by bumping this dependency to v0.49.0 and change the use of v1alpha1.Run to v1beta1.CustomRun.
I'm planning on opening separate PRs to support v1.PipelineRun and bring back support for podTemplate.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:
See the contribution guide for more details.