search

tektoncd / experimental

Experimental Tekton Components
Apache License 2.0
100 stars 121 forks source link

[PIP] Support the cancellation and timeout for customRun #950

Closed sallyyama closed 1 year ago

sallyyama commented 1 year ago

The Pipelines-in-Pipelines is provided by a controller that implements the Custom Task interface. Currently, the cancellation is not implemented for the customRun so when the main pipelineRun is cancelled, the pipelineRuns spawned by the customRuns won't be cancelled accordingly, which can lead to confusion. And also, timeout cannot be specified for the pipelineRun so it can only inherit the default timeout.

This PR addresses the above issues, by cancelling the spawned pipelineRuns when the corresponding customRuns are marked as Cancelled and also loading timeout from customRun's spec.

tekton-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign afrittoli after the PR has been reviewed. You can assign the PR to them by writing /assign @afrittoli in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[pipelines-in-pipelines/OWNERS](https://github.com/tektoncd/experimental/blob/main/pipelines-in-pipelines/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
linux-foundation-easycla[bot] commented 1 year ago

CLA Not Signed

tekton-robot commented 1 year ago

Hi @sallyyama. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.