Closed vdemeester closed 1 year ago
cc @jerop @afrittoli
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dibyom
The full list of commands accepted by this bot can be found here.
The pull request process is described here
FWIW, I don't think we strictly need licenses here as long as they're apache 2, since the top level repo already defines a license?
Yes I tend to agree, but go-license
didn't as it treats each go project (defined by a go.mod
) separately, and thus was failing for most of them.
Changes
Trying to fix the experimental CI.
generators
and other projects that are missing ittask-loops
CI (doesn't work anymore)gofmt
on go filesSigned-off-by: Vincent Demeester vdemeest@redhat.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:
See the contribution guide for more details.