tektoncd / experimental

Experimental Tekton Components
Apache License 2.0
99 stars 121 forks source link

generators: add a LICENSE and bump plumbing #954

Closed vdemeester closed 1 year ago

vdemeester commented 1 year ago

Changes

Trying to fix the experimental CI.

Signed-off-by: Vincent Demeester vdemeest@redhat.com

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

See the contribution guide for more details.

vdemeester commented 1 year ago

cc @jerop @afrittoli

tekton-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/experimental/blob/main/OWNERS)~~ [dibyom] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
vdemeester commented 1 year ago

FWIW, I don't think we strictly need licenses here as long as they're apache 2, since the top level repo already defines a license?

Yes I tend to agree, but go-license didn't as it treats each go project (defined by a go.mod) separately, and thus was failing for most of them.