tektoncd / operator

Kubernetes operator to manage installation, updation and uninstallation of tektoncd projects (pipeline, …)
Apache License 2.0
445 stars 193 forks source link

Link broken on tektoncd/operator/blob/main/DEVELOPMENT.md #1914

Open T3-git opened 10 months ago

T3-git commented 10 months ago

Expected Behavior

On https://github.com/tektoncd/operator/blob/main/DEVELOPMENT.md when clicking the link in

To setup a cluster with GKE:

Install required tools and setup GCP project (You may find it useful to save the ID of the project in an environment variable (e.g. PROJECT_ID).

you will be lead to a file not found page.

Actual Behavior

This link should link to a markdown document describing Knative-with-GKE.md or if this document no longer exists, a replacement solution should be provided.

Steps to Reproduce the Problem

  1. Open DEVELOPMENT.md
  2. Click the link under to setup a cluster with GKE
T3-git commented 10 months ago

/kind documentation /good-first-issue

tekton-robot commented 10 months ago

@T3-git: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/tektoncd/operator/issues/1914): >/kind documentation >/good-first-issue Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
SD-13 commented 10 months ago

Did a little digging and looks like the doc was removed in https://github.com/knative/docs/pull/2170

professorabhay commented 10 months ago

Do we have to remove that part?

T3-git commented 10 months ago

Maybe I wasnt the best canidate to report this(I'm, also new). Seems like @SD-13 found thats its been moved to one large file if I read correctly so I would assume we would verify that section is still there and update the link accordingly. SD-13 might be working this though since they tracked down the commit.

SD-13 commented 10 months ago

I think we should replace the old link with this README if we don't want to refactor this doc.

kumarankit999 commented 10 months ago

Yes, It would be great @SD-13!

SD-13 commented 10 months ago

I will open a PR for it!

Srish-ty commented 3 days ago

@T3-git I've added PR linked with this issue: https://github.com/knative/docs/pull/6151 please review