search

tektoncd / operator

Kubernetes operator to manage installation, updation and uninstallation of tektoncd projects (pipeline, …)
Apache License 2.0
442 stars 191 forks source link

make rbac max concurrent calls configurable #2331

Closed jkhelil closed 1 week ago

jkhelil commented 1 week ago

Changes

Improvements for Namespace RBAC Reconciliation on OpenShift

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

See the contribution guide for more details.

Release Notes

Add an environment variable OCP_RBAC_MAX_CONCURRENT_CALLS to configure the maximum number of concurrent calls for namespace RBAC reconciliation.
This is particularly useful for clusters with a large number of namespaces.
tekton-robot commented 1 week ago

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonconfig/rbac.go 45.2% 45.4% 0.1
jkhelil commented 1 week ago

/release-note-none

tekton-robot commented 1 week ago

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonconfig/rbac.go 45.2% 45.3% 0.1
tekton-robot commented 1 week ago

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonconfig/init.go Do not exist 100.0%
jkhelil commented 1 week ago

@khrm @jkandasa Can you have a look please

tekton-robot commented 1 week ago

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonconfig/init.go Do not exist 100.0%
tekton-robot commented 1 week ago

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonconfig/init.go Do not exist 100.0%
tekton-robot commented 1 week ago

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonconfig/init.go Do not exist 100.0%
tekton-robot commented 1 week ago

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonconfig/init.go Do not exist 100.0%
pkg/reconciler/openshift/tektonconfig/rbac.go 45.2% 45.3% 0.0
tekton-robot commented 1 week ago

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonconfig/init.go Do not exist 100.0%
pkg/reconciler/openshift/tektonconfig/rbac.go 45.2% 45.3% 0.0
tekton-robot commented 1 week ago

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonconfig/init.go Do not exist 100.0%
pkg/reconciler/openshift/tektonconfig/rbac.go 45.2% 45.6% 0.3
tekton-robot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkandasa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/operator/blob/main/OWNERS)~~ [jkandasa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jkandasa commented 1 week ago

@jkhelil in the release notes, please describe about the new environment variable also include the description about the PR

jkandasa commented 1 week ago

/cherry-pick release-v0.73.x

tekton-robot commented 1 week ago

@jkandasa: once the present PR merges, I will cherry-pick it on top of release-v0.73.x in a new PR and assign it to you.

In response to [this](https://github.com/tektoncd/operator/pull/2331#issuecomment-2366975772): >/cherry-pick release-v0.73.x Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jkandasa commented 1 week ago

/lgtm

tekton-robot commented 1 week ago

@jkandasa: new pull request created: #2337

In response to [this](https://github.com/tektoncd/operator/pull/2331#issuecomment-2366975772): >/cherry-pick release-v0.73.x Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.