search

tektoncd / operator

Kubernetes operator to manage installation, updation and uninstallation of tektoncd projects (pipeline, …)
Apache License 2.0
445 stars 197 forks source link

Add resolverStepActions flag to enable/disable stepaction #2338

Closed savitaashture closed 1 month ago

savitaashture commented 1 month ago

Instead of using resolverTasks flag added new resolverStepActions flag to enable or disable stepactions separately

Signed-off-by: Savita Ashture sashture@redhat.com

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

See the contribution guide for more details.

Release Notes

savitaashture commented 1 month ago

cc @Aneesh-M-Bhat

savitaashture commented 1 month ago

/cherry-pick release-v0.73.x

tekton-robot commented 1 month ago

@savitaashture: once the present PR merges, I will cherry-pick it on top of release-v0.73.x in a new PR and assign it to you.

In response to [this](https://github.com/tektoncd/operator/pull/2338#issuecomment-2367470957): >/cherry-pick release-v0.73.x Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Aneesh-M-Bhat commented 1 month ago

Tested it for resolverTasks = true/false & resolverStepActions = true/false ( for all 4 situations ) & yep the stepactions & tasks had the correct behaviour. :smile: LGTM. /lgtm

tekton-robot commented 1 month ago

@Aneesh-M-Bhat: changing LGTM is restricted to collaborators

In response to [this](https://github.com/tektoncd/operator/pull/2338#issuecomment-2367845686): >Tested it for resolverTasks = true/false & resolverStepActions = true/false ( for all 4 situations ) & yep the stepactions & tasks had the correct behaviour. :smile: >LGTM. >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
tekton-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkandasa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/operator/blob/main/OWNERS)~~ [jkandasa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tekton-robot commented 1 month ago

@savitaashture: new pull request created: #2339

In response to [this](https://github.com/tektoncd/operator/pull/2338#issuecomment-2367470957): >/cherry-pick release-v0.73.x Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.