search

tektoncd / operator

Kubernetes operator to manage installation, updation and uninstallation of tektoncd projects (pipeline, …)
Apache License 2.0
442 stars 191 forks source link

[main] ignore enable-tekton-oci-bundles feature flag #2344

Closed jkandasa closed 3 days ago

jkandasa commented 6 days ago

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

See the contribution guide for more details.

Release Notes

pipeline feature flag `enable-tekton-oci-bundles` will be ignored.
tekton-robot commented 6 days ago

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonpipeline_defaults.go 93.4% 93.3% -0.1
pkg/reconciler/kubernetes/tektonpipeline/transform.go 78.5% 89.8% 11.3
tekton-robot commented 6 days ago

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonpipeline_defaults.go 93.4% 93.3% -0.1
pkg/reconciler/kubernetes/tektonpipeline/transform.go 78.5% 89.8% 11.3
jkandasa commented 6 days ago

/test pull-tekton-operator-integration-tests

PuneetPunamiya commented 5 days ago

Thanks 🤙🏻 /approve

tekton-robot commented 5 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PuneetPunamiya, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/operator/blob/main/OWNERS)~~ [PuneetPunamiya,vdemeester] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
savitaashture commented 3 days ago

tested fresh and upgrade scenario works fine

Thank you LGTM

@PuneetPunamiya lets merge when your comment https://github.com/tektoncd/operator/pull/2344#discussion_r1774543941 resolve

savitaashture commented 3 days ago

tested fresh and upgrade scenario works fine

Thank you LGTM

@PuneetPunamiya lets merge when your comment #2344 (comment) resolve

As per the discussion with Puneet merging this PR now But @jkandasa whenever you are back from PTO take care of that comment thank you

/lgtm

savitaashture commented 3 days ago

/cherry-pick release-v0.73.x

tekton-robot commented 3 days ago

@savitaashture: once the present PR merges, I will cherry-pick it on top of release-v0.73.x in a new PR and assign it to you.

In response to [this](https://github.com/tektoncd/operator/pull/2344#issuecomment-2377473840): >/cherry-pick release-v0.73.x Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
tekton-robot commented 3 days ago

@savitaashture: new pull request created: #2351

In response to [this](https://github.com/tektoncd/operator/pull/2344#issuecomment-2377473840): >/cherry-pick release-v0.73.x Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.