tektoncd / operator

Kubernetes operator to manage installation, updation and uninstallation of tektoncd projects (pipeline, …)

Apache License 2.0

442 stars 191 forks source link

Revert rbac optim #2348

Closed jkhelil closed 4 days ago

jkhelil commented 4 days ago

Changes

CreateResource function is ensuring rbac resource for opensift namespaces. When implemented through concurrency, we observed unstability due the fact that concurrent workers tries to update a shared object clusterinterceptor cluster role binding. concurrency seems not bring improvement in performance, and bring unstability The fix reverts concurrency implementation and fixes the creates resource function to not block the hole reconciliation when an issue is observed for one namespace

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

[ ] Run make test lint before submitting a PR
[ ] Includes tests (if functionality changed/added)
[ ] Includes docs (if user facing)
[ ] Commit messages follow commit message best practices

See the contribution guide for more details.

Release Notes

tekton-robot commented 4 days ago

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/openshift/tektonconfig/common.go	54.8%	0.0%	-54.8
pkg/reconciler/openshift/tektonconfig/rbac.go	45.6%	0.0%	-45.6

tekton-robot commented 4 days ago

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/openshift/tektonconfig/common.go	54.8%	0.0%	-54.8
pkg/reconciler/openshift/tektonconfig/rbac.go	45.6%	0.0%	-45.6

savitaashture commented 4 days ago

Tested locally by upgrading from release-v0.71.x to this PR changes Steps:

Installed Operator from release-v0.71.x branch
Created tls eventlistener under releasetest-upgrade-tls ns and verified its working by sending request
Upgraded Operator with this PR changes
Observed that releasetest-upgrade-tls namespace has not removed from openshift-pipelines-clusterinterceptors clusterrolebinding
Sent request to EL and verified its success

tekton-robot commented 4 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: savitaashture

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/operator/blob/main/OWNERS)~~ [savitaashture] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

savitaashture commented 4 days ago

cc @PuneetPunamiya

PuneetPunamiya commented 4 days ago

/lgtm

jkhelil commented 4 days ago

/cherry-pick release-v0.73.x

tekton-robot commented 4 days ago

@jkhelil: new pull request created: #2349

In response to [this](https://github.com/tektoncd/operator/pull/2348#issuecomment-2376803673): >/cherry-pick release-v0.73.x Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.