Closed maxres-fr closed 4 years ago
I believe this is a dupe of #2282 and should be resolved by https://github.com/tektoncd/pipeline/pull/2320 ?
Whoa cool! Sorry for putting you though writing up an issue about this @maxres-fr i didnt know about those others, but the good news is that it looks like we almost have a fix already :D
@sbwsg @bobcatfish going to close this, I missed that!
Expected Behavior
A resource type of git should fetch and check out a tag if the revision parameter is a git tag.
Where
params.gitrevision
is a git tag.I expected that the task's workspace would have the tag checked out. e.g where the tag is
2020-04-06-AllaNorma
runninggit status
should look likeActual Behavior
Tags are not fetched, the tag isn't checked out. Logs indicate it was, but the repo remains on master and has no tag refs from the cloned remote.
Steps to Reproduce the Problem
Additional Info
Kubernetes version:
Output of
kubectl version
:Tekton Pipeline version:
Output of
tkn version
orkubectl get pods -n tekton-pipelines -l app=tekton-pipelines-controller -o=jsonpath='{.items[0].metadata.labels.version}'
Based on a conversation on the tektoncd slack channel, it's believed that the issue is in this func https://github.com/tektoncd/pipeline/blob/6b1579c89d75ec4e58c5630819429709e21f7332/pkg/git/git.go#L59-L107