tektoncd / pipeline

A cloud-native Pipeline resource.
https://tekton.dev
Apache License 2.0
8.51k stars 1.78k forks source link

Task defined as finally is started, even though other tasks never completed #6637

Closed pratap0007 closed 8 months ago

pratap0007 commented 1 year ago

Expected Behavior

Finally Task should only start running when all previous Task are completed (no matter if successful or not successful). Meaning finally should only trigger if all Task have completionTime set.

Actual Behavior

The PipelineRun completed with problems as finally ran before all other Task had completionTime set and thus finally was failing.

Steps to Reproduce the Problem

  1. Create Pipeline containing few tasks and finally task
  2. Start the Pipeline

Additional Info

Pipeline version: v0.37.3
lbernick commented 1 year ago

@pratap0007 could you please provide your pipeline + pipelinerun yaml + status?

tekton-robot commented 1 year ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale with a justification. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

pratap0007 commented 1 year ago

/remove-lifecycle stale

lbernick commented 1 year ago

@pratap0007 bumping my previous comment; having this information will help us reproduce this issue. If you're able to try reproducing your issue on a current version of Pipelines, that would also be helpful.

tekton-robot commented 1 year ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale with a justification. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

vdemeester commented 8 months ago

Closing this, no updates so assuming this was fixed or workaround