search

tektoncd / pipeline

A cloud-native Pipeline resource.
https://tekton.dev
Apache License 2.0
8.44k stars 1.77k forks source link

PVC not deleted if PipelineRun deleted while still running #7618

Open jimmyjones2 opened 7 months ago

jimmyjones2 commented 7 months ago

Expected Behavior

In coschedule: pipelineruns mode, when a PipelineRun that is still running is deleted, the associated PVC created by the volumeClaimTemplate is also deleted.

Actual Behavior

The created PVC is not deleted. This is unlike deleting a finished PipelineRun, where the PVC will be deleted.

Steps to Reproduce the Problem

  1. Enable coschedule: pipelineruns
  2. Create a PipelineRun with a volumeClaimTemplate
  3. Delete the PipelineRun before it completes

Additional Info

@QuanZhang-William related to #7138 ?

Server Version: version.Info{Major:"1", Minor:"27", GitVersion:"v1.27.4", GitCommit:"fa3d7990104d7c1f16943a67f11b154b71f6a132", GitTreeState:"clean", BuildDate:"2023-07-19T12:14:49Z", GoVersion:"go1.20.6", Compiler:"gc", Platform:"linux/amd64"}
v0.53.0
vdemeester commented 7 months ago

cc @pritidesai @JeromeJu @jerop

jimmyjones2 commented 4 months ago

@QuanZhang-William @gerrnot Did you manage to reproduce?

gerrnot commented 4 months ago

yes, reproducible with tkn version:

Client version: 0.36.0
Chains version: v0.20.0
Pipeline version: v0.56.1
Triggers version: v0.26.1
Dashboard version: v0.43.1
Operator version: v0.70.0