tektoncd / pipeline

A cloud-native Pipeline resource.
https://tekton.dev
Apache License 2.0
8.35k stars 1.76k forks source link

Tests before promoting LargerResults via Sidecarlogs to Beta #8041

Closed chitrangpatel closed 3 weeks ago

chitrangpatel commented 3 weeks ago

https://github.com/tektoncd/pipeline/issues/6133 identified missing example/e2e tests to complete before promoting Larger Results via Sidecar Logs to Beta. This PR updates the e2e tests with:

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Release Notes

NONE

/kind test

tekton-robot commented 3 weeks ago

@chitrangpatel: The label(s) kind/test cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/tektoncd/pipeline/pull/8041): >https://github.com/tektoncd/pipeline/issues/6133 identified missing example/e2e tests to complete before promoting Larger Results via Sidecar Logs to Beta. This PR updates the e2e tests with: >* Multiple Tasks with Multiple Results in a Pipeline >* A Step producing Result fails with OnError continue >* A Failed Task in the Pipeline > > > ># Changes > > > ># Submitter Checklist > >As the author of this PR, please check off the items in this checklist: > >- [ ] Has [Docs](https://github.com/tektoncd/community/blob/main/standards.md#docs) if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps >- [ ] Has [Tests](https://github.com/tektoncd/community/blob/main/standards.md#tests) included if any functionality added or changed >- [ ] [pre-commit](https://github.com/tektoncd/pipeline/blob/main/DEVELOPMENT.md#install-tools) Passed >- [ ] Follows the [commit message standard](https://github.com/tektoncd/community/blob/main/standards.md#commits) >- [ ] Meets the [Tekton contributor standards](https://github.com/tektoncd/community/blob/main/standards.md) (including functionality, content, code) >- [ ] Has a kind label. You can add one by adding a comment on this PR that contains `/kind `. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep >- [ ] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of [good release notes](https://github.com/tektoncd/community/blob/main/standards.md#good-release-notes). >- [ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release > ># Release Notes > >```release-note >NONE >``` >/kind test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
chitrangpatel commented 3 weeks ago

/kind testing

chitrangpatel commented 3 weeks ago

/kind misc

chitrangpatel commented 3 weeks ago

/retest

tekton-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JeromeJu, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/pipeline/blob/main/OWNERS)~~ [JeromeJu,vdemeester] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
JeromeJu commented 3 weeks ago

/lgtm

chitrangpatel commented 3 weeks ago

/retest