tektoncd / pipeline

A cloud-native Pipeline resource.
https://tekton.dev
Apache License 2.0
8.5k stars 1.78k forks source link

When performing an upgrade using install.yaml, a pipeline that ran in the past is now running. #8045

Open kengowada-41 opened 5 months ago

kengowada-41 commented 5 months ago

Expected Behavior

The upgrade should be completed without running past pipelines.

Actual Behavior

Past pipeline is up and running. Major problems occurred in the past as pipelines went live.

Steps to Reproduce the Problem

1.Upgraded by applying install.yaml 2.Past pipeline was up and running after upgrade. 3.pipeline had a failure status when checked with tkn pr list, but the pipeline was actually running and a major problem occurred

Additional Info

WARNING: This version information is deprecated and will be replaced with the output from kubectl version --short.  Use --output=yaml|json to get the full version.
Client Version: version.Info{Major:"1", Minor:"26", GitVersion:"v1.26.11", GitCommit:"3cd242c51317aed8858119529ccab22079f523b1", GitTreeState:"clean", BuildDate:"2023-11-15T17:00:54Z", GoVersion:"go1.20.11", Compiler:"gc", Platform:"linux/amd64"}
Kustomize Version: v4.5.7
Server Version: version.Info{Major:"1", Minor:"25", GitVersion:"v1.25.16+054f0ba", GitCommit:"f5b7c3e8faedd51935d77828a5fc72c7540236f4", GitTreeState:"clean", BuildDate:"2024-04-15T13:49:12Z", GoVersion:"go1.19.13 X:strictfipsruntime", Compiler:"gc", Platform:"linux/amd64"}
Client version: 0.26.1
Pipeline version: v0.56.3
Triggers version: v0.26.1
Dashboard version: v0.45.0

I want to know why past pipelines have moved with the upgrade. install.yaml

YutoSekikawa commented 5 months ago

We performed a reproduction test using the following procedure, and reproduced the problem with a specific version.

  1. Install "From version" of tekton-pipeline.
  2. Create a task and pipeline, execute pipelinerun, and confirm normal termination.
  3. Delete the pod that is the actual state of the executed task (leave pipelinerun as it is)
  4. Install "To version" of tekton-pipeline.   →The pipelinerun that was Succeeded in step 2 above is re-executed.

The version transition where the event occurred From version To Version v0.41.2 -> v0.56.3 v0.41.2 -> v0.50.0 v0.44.4 -> v0.50.0

Version transition where the event did not occur From Version To Version v0.41.2 -> v0.47.8 -> v0.50.0 v0.41.2 -> v0.44.4 v0.44.4 -> v0.47.8

From the reproducibility test, it seems that the problem is reproduced when the v0.44.4 -> v0.50.0 part is done in a single version update. We are wondering if there might be a latent problem in this VersionUp that could lead to the reproduction of the event.

Could you please check?