search

tektoncd / pipeline

A cloud-native Pipeline resource.
https://tekton.dev
Apache License 2.0
8.35k stars 1.76k forks source link

Remove bobcatfish and lbernick from OWNERS 😿 #8047

Closed vdemeester closed 2 weeks ago

vdemeester commented 3 weeks ago

Changes

@bobcatfish and @lbernick are not working on tektoncd anymore, thus it doesn't make sense to keep them as OWNERS in the project.

Thank you both for everything you did on the project 🤗.

Signed-off-by: Vincent Demeester vdemeest@redhat.com

/kind misc /meow sad

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Release Notes

NONE
tekton-robot commented 3 weeks ago

@vdemeester: cat image

In response to [this](https://github.com/tektoncd/pipeline/pull/8047): > > > ># Changes > >@bobcatfish and @lbernick are not working on tektoncd anymore, thus it >doesn't make sense to keep them as OWNERS in the project. > >Thank you both for everything you did on the project 🤗. > >Signed-off-by: Vincent Demeester > >/kind misc >/meow sad > > > ># Submitter Checklist > >As the author of this PR, please check off the items in this checklist: > >- [ ] Has [Docs](https://github.com/tektoncd/community/blob/main/standards.md#docs) if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps >- [ ] Has [Tests](https://github.com/tektoncd/community/blob/main/standards.md#tests) included if any functionality added or changed >- [x] [pre-commit](https://github.com/tektoncd/pipeline/blob/main/DEVELOPMENT.md#install-tools) Passed >- [x] Follows the [commit message standard](https://github.com/tektoncd/community/blob/main/standards.md#commits) >- [x] Meets the [Tekton contributor standards](https://github.com/tektoncd/community/blob/main/standards.md) (including functionality, content, code) >- [x] Has a kind label. You can add one by adding a comment on this PR that contains `/kind `. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep >- [ ] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of [good release notes](https://github.com/tektoncd/community/blob/main/standards.md#good-release-notes). >- [ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release > ># Release Notes > >```release-note >NONE >``` > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
vdemeester commented 3 weeks ago

/assign @afrittoli @chitrangpatel @JeromeJu @dibyom @jerop

chitrangpatel commented 3 weeks ago

/test check-pr-has-kind-label

tekton-robot commented 3 weeks ago

@chitrangpatel: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/tektoncd/pipeline/pull/8047#issuecomment-2163091046): >/test check-pr-has-kind-label Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
chitrangpatel commented 3 weeks ago

/retest

vdemeester commented 3 weeks ago

@chitrangpatel I think pull-tekton-pipeline-go-coverage-df is not required (look at the tide check) so I think we are fine with it being 🔴

chitrangpatel commented 3 weeks ago

Thank you @bobcatfish, @lbernick !!! /approve

tekton-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chitrangpatel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/pipeline/blob/main/OWNERS)~~ [chitrangpatel] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
lbernick commented 3 weeks ago

❤️

tekton-robot commented 2 weeks ago

@khrm: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/tektoncd/pipeline/pull/8047#pullrequestreview-2113781557): >/test pull-tekton-pipeline-go-coverage-df > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
afrittoli commented 2 weeks ago

Sad PR :( /lgtm

vdemeester commented 2 weeks ago

/test pull-tekton-pipeline-go-coverage-df /test pull-tekton-pipeline-go-coverage

vdemeester commented 2 weeks ago

/override pull-tekton-pipeline-go-coverage-df

vdemeester commented 2 weeks ago 
repository 'https://github.com/$(tasks.split-full-repo-name.results.repoOwner)/$(tasks.split-full-repo-name.results.repoName).git/' not found

🤔

vdemeester commented 2 weeks ago

/test pull-tekton-pipeline-go-coverage-df

tekton-robot commented 2 weeks ago

@vdemeester: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/tektoncd/pipeline/pull/8047#issuecomment-2175133285): >/test pull-tekton-pipeline-go-coverage-df Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
vdemeester commented 2 weeks ago

@tektoncd/plumbing-maintainers there is an issue with the reports of the tekton-powered jobs. pull-tekton-pipeline-go-coverage-df is still running but the check is marked as successful already.

vdemeester commented 2 weeks ago

(It did succeed this time though)