Closed vdemeester closed 2 weeks ago
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/reconciler/pipelinerun/resources/pipelineref.go | 94.1% | 94.3% | 0.2 |
pkg/reconciler/taskrun/resources/taskref.go | 94.0% | 94.2% | 0.2 |
cc @JeromeJu @chitrangpatel This probably need some tests (unit at least), a release note and some refactoring, but does the approach sounds alright ? Also, we can list other fields we may want to clean.
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/reconciler/pipelinerun/resources/pipelineref.go | 94.1% | 94.3% | 0.2 |
pkg/reconciler/taskrun/resources/taskref.go | 94.0% | 94.2% | 0.2 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/reconciler/pipelinerun/resources/pipelineref.go | 94.1% | 94.3% | 0.2 |
pkg/reconciler/taskrun/resources/taskref.go | 94.0% | 94.2% | 0.2 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/reconciler/pipelinerun/resources/pipelineref.go | 94.1% | 94.3% | 0.2 |
pkg/reconciler/taskrun/resources/taskref.go | 94.0% | 94.2% | 0.2 |
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: chitrangpatel
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Right now, we only use dryRun to Validate. If users have mutating admission webhooks on the cluster then when we do the dryRun and validate, the mutations will happen before the validation. However, we ignore the mutated object and only continue with the original runtime Object even though we have validated the mutated one. In practice, when we do the dryrun, we should return the mutated object in addition to the validation error so that we use the mutated object in the underlying spec.
Ah that's a good point, we should probably track this into an issue.
/cherry-pick v0.59.x
@vdemeester: once the present PR merges, I will cherry-pick it on top of v0.59.x in a new PR and assign it to you.
/cherry-pick v0.56.x
@vdemeester: once the present PR merges, I will cherry-pick it on top of v0.56.x in a new PR and assign it to you.
/cherry-pick v0.53.x
@vdemeester: once the present PR merges, I will cherry-pick it on top of v0.53.x in a new PR and assign it to you.
/cherry-pick v0.50.x
@vdemeester: once the present PR merges, I will cherry-pick it on top of v0.50.x in a new PR and assign it to you.
/lgtm
@savitaashture: changing LGTM is restricted to collaborators
/lgtm
@jkandasa: changing LGTM is restricted to collaborators
/lgtm
@vdemeester: cannot checkout v0.59.x
: error checking out v0.59.x: exit status 1. output: error: pathspec 'v0.59.x' did not match any file(s) known to git
@vdemeester: cannot checkout v0.56.x
: error checking out v0.56.x: exit status 1. output: error: pathspec 'v0.56.x' did not match any file(s) known to git
@vdemeester: cannot checkout v0.53.x
: error checking out v0.53.x: exit status 1. output: error: pathspec 'v0.53.x' did not match any file(s) known to git
@vdemeester: cannot checkout v0.50.x
: error checking out v0.50.x: exit status 1. output: error: pathspec 'v0.50.x' did not match any file(s) known to git
/cherry-pick release-v0.59.x
@vdemeester: #8051 failed to apply on top of branch "release-v0.59.x":
Applying: Cleanup resolved object before validating through dry-run
Using index info to reconstruct a base tree...
M pkg/reconciler/pipelinerun/resources/pipelineref.go
M pkg/reconciler/taskrun/resources/taskref.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/reconciler/taskrun/resources/taskref.go
CONFLICT (content): Merge conflict in pkg/reconciler/taskrun/resources/taskref.go
Auto-merging pkg/reconciler/pipelinerun/resources/pipelineref.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Cleanup resolved object before validating through dry-run
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Arf⦠I'll have to manually cherry-pick..
Changes
This ensure that we are not going to fail during validation with dry-run. An example of such a failure would be the following scenario.
ownerReferences
withblockOwnerDeletion: true
cluster
resolver to fetch that task/kind bug
Signed-off-by: Vincent Demeester vdemeest@redhat.com
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes