vdemeester commented 2 weeks ago

Changes

Cherry picked fro #8051

This ensure that we are not going to fail during validation with dry-run. An example of such a failure would be the following scenario.

A task in a namespace has ownerReferences with blockOwnerDeletion: true
A user uses the cluster resolver to fetch that task
That user doesn't have a lot of rights in that namespace (only listing Tasks for example).

/kind bug

Signed-off-by: Vincent Demeester vdemeest@redhat.com

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

[ ] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
[ ] Has Tests included if any functionality added or changed
[x] pre-commit Passed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including functionality, content, code)
[x] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[x] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
[ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Cleanup resolved object before attempting to validate it through api dry-run call

vdemeester commented 2 weeks ago

/retest

vdemeester commented 2 weeks ago

/retest

vdemeester commented 2 weeks ago

/test pull-tekton-pipeline-go-coverage-df

tekton-robot commented 2 weeks ago

@vdemeester: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

/test pull-tekton-pipeline-alpha-integration-tests
/test pull-tekton-pipeline-beta-integration-tests
/test pull-tekton-pipeline-build-tests
/test pull-tekton-pipeline-integration-tests
/test pull-tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

/test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to [this](https://github.com/tektoncd/pipeline/pull/8063#issuecomment-2175591749): >/test pull-tekton-pipeline-go-coverage-df Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

tekton-robot commented 2 weeks ago

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/resources/pipelineref.go	94.3%	93.8%	-0.6
pkg/reconciler/taskrun/resources/taskref.go	94.2%	94.4%	0.2

vdemeester commented 2 weeks ago

/retest

vdemeester commented 2 weeks ago

/test pull-tekton-pipeline-go-coverage

tekton-robot commented 2 weeks ago

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/resources/pipelineref.go	94.3%	93.8%	-0.6
pkg/reconciler/taskrun/resources/taskref.go	94.2%	94.4%	0.2

tekton-robot commented 2 weeks ago

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/resources/pipelineref.go	94.3%	93.8%	-0.6
pkg/reconciler/taskrun/resources/taskref.go	94.2%	94.4%	0.2

chitrangpatel commented 2 weeks ago

/retest

chitrangpatel commented 2 weeks ago

/retest

chitrangpatel commented 1 week ago

/approve /lgtm

tekton-robot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chitrangpatel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/pipeline/blob/release-v0.59.x/OWNERS)~~ [chitrangpatel] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

tektoncd / pipeline

[release-v0.59.x] Cleanup resolved object before validating through dry-run #8063

Changes

Submitter Checklist

Release Notes