tektoncd / pipeline

A cloud-native Pipeline resource.
https://tekton.dev
Apache License 2.0
8.35k stars 1.76k forks source link

Using image with "full" reference in tests #8070

Closed vdemeester closed 22 hours ago

vdemeester commented 2 weeks ago

Changes

This moves any "implicit" references (such as busybox or ubuntu) to full references instead (docker.io/library/busybox, …).

This is related to https://github.com/tektoncd/pipeline/issues/4551. This would help us identify all images using docker.io used in tests and thus migrate from them in the future.

Signed-off-by: Vincent Demeester vdemeest@redhat.com

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Release Notes

NONE
tekton-robot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chitrangpatel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/pipeline/blob/main/OWNERS)~~ [chitrangpatel] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
chitrangpatel commented 2 weeks ago

/test check-pr-has-kind-label

tekton-robot commented 2 weeks ago

@chitrangpatel: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/tektoncd/pipeline/pull/8070#issuecomment-2178951653): >/test check-pr-has-kind-label Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
vdemeester commented 1 week ago

/retest

vdemeester commented 1 day ago

@JeromeJu @afrittoli ptal 🙏🏼

JeromeJu commented 1 day ago

/lgtm

AlanGreene commented 23 hours ago

/retest