tektoncd / pipeline

A cloud-native Pipeline resource.
https://tekton.dev
Apache License 2.0
8.35k stars 1.76k forks source link

chore: remove unsupported configurations `ScopeWhenExpressionsToTask` #8078

Closed l-qing closed 1 hour ago

l-qing commented 1 week ago

This feature flag has been completely removed in v0.35.

Ref:

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Release Notes

NONE

/kind misc

tekton-robot commented 1 week ago

Hi @l-qing. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
tekton-robot commented 7 hours ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/apis/OWNERS](https://github.com/tektoncd/pipeline/blob/main/pkg/apis/OWNERS)~~ [vdemeester] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
l-qing commented 6 hours ago

/retest

tekton-robot commented 6 hours ago

@l-qing: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/tektoncd/pipeline/pull/8078#issuecomment-2205524084): >/retest Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
vdemeester commented 6 hours ago

/ok-to-test

vdemeester commented 6 hours ago

/retest

l-qing commented 5 hours ago

/retest

l-qing commented 3 hours ago

/retest