Open ralphbean opened 5 days ago
Hi @ralphbean. Thanks for your PR.
I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/kind bug
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go | 96.7% | 96.5% | -0.2 |
pkg/reconciler/pipelinerun/resources/resultrefresolution.go | 99.2% | 98.3% | -0.8 |
I'm not sure how the test coverage drop is possible. I added tests to cover the new branches.
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go | 96.7% | 96.5% | -0.2 |
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: vdemeester
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@afrittoli @chitrangpatel @JeromeJu ptal 🙏🏼 We'll want to cherry-pick this for LTSes as well.
/lgtm
/retest
Before this change, it was possible for a PipelineRun to exist which would cause the controller to crash in CheckMissingResultReferences.
Changes
Handle error conditions in CheckMissingResultReferences, fixing https://github.com/tektoncd/pipeline/issues/8083
Plus, added tests to cover the scenarios.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease notes contains the string "action required" if the change requires additional action from users switching to the new releaseRelease Notes