search

tektoncd / pipeline

A cloud-native Pipeline resource.
https://tekton.dev
Apache License 2.0
8.5k stars 1.78k forks source link

[release-v0.59.x] Run finally pipeline even if task is failed at the validation #8369

Closed tekton-robot closed 2 weeks ago

tekton-robot commented 2 weeks ago

This is an automated cherry-pick of #8314

/assign vdemeester

NONE
vdemeester commented 2 weeks ago

/kind bug /approve /lgtm

tekton-robot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/pipeline/blob/release-v0.59.x/OWNERS)~~ [vdemeester] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tekton-robot commented 2 weeks ago

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 91.7% 91.8% 0.1
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.2% 96.0% -0.2
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 99.2% 99.2% -0.0
pkg/reconciler/pipelinerun/resources/resultrefresolution.go 98.4% 98.3% -0.1
tekton-robot commented 2 weeks ago

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 91.7% 91.8% 0.1
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.2% 96.0% -0.2
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 99.2% 99.2% -0.0
pkg/reconciler/pipelinerun/resources/resultrefresolution.go 98.4% 98.3% -0.1