search

tektoncd / plumbing

This repo holds configuration for infrastructure used across the tektoncd org 🏗️
Apache License 2.0
60 stars 110 forks source link

Create pre-commit hook configuration for running presubmits #180

Closed wlynch closed 4 years ago

wlynch commented 4 years ago

Expected Behavior

I should be able to catch common presubmit issues prior to creating a PR.

Actual Behavior

I forget to run golang-ci and doc linters/formaters, push my code anyway, get a notification ~5 mins later that I don't actually read until ~30 mins later that I need to format a file.

Additional Info

We should set up recommended pre-commit/push hooks to automatically run common tests/linting/etc. This should be a pruned set of tests to be relatively fast - O(seconds).

https://pre-commit.com/ has been suggested as a mechanism to manage these. Alternatively, we could just have a script to use git-hooks directly (https://git-scm.com/book/en/v2/Customizing-Git-Git-Hooks)

vdemeester commented 4 years ago

/kind feature /area config

tekton-robot commented 4 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with /close.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

tekton-robot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close.

/lifecycle stale

Send feedback to tektoncd/plumbing.

tekton-robot commented 4 years ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

tekton-robot commented 4 years ago

@tekton-robot: Closing this issue.

In response to [this](https://github.com/tektoncd/plumbing/issues/180#issuecomment-673265911): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >/close > >Send feedback to [tektoncd/plumbing](https://github.com/tektoncd/plumbing). Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.