search

tektoncd / results

Long term storage of execution results.
Apache License 2.0
77 stars 73 forks source link

Update kustomization files to latest standard #440

Closed Roming22 closed 1 year ago

Roming22 commented 1 year ago

This removes deprecation warning when applying kustomize to the files.

There should be no impact on any functionality. This was verified by making sure that the output of kustomize build path/to/dir was identical before and after the change.

The only change detected is that config/components/local-db would previously exit in error (Error: no matches for Id Deployment.v1.apps/api.tekton-pipelines; failed to find unique target for patch Deployment.v1.apps/api.tekton-pipelines), but is built successfully after the change. I believe this is not a breaking change as the kustomization.yaml in that directory was not intended to be used by itself.

Changes

cleanup.

This PR cleans up the kustomization.yaml to remove deprecation warnings output by kustomize on the latest version (v5.0.1).

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

Release Notes

No user facing changes.

NONE
linux-foundation-easycla[bot] commented 1 year ago

CLA Signed

The committers listed above are authorized under a signed CLA.

tekton-robot commented 1 year ago

Hi @Roming22. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Roming22 commented 1 year ago

/kind cleanup

avinal commented 1 year ago

/ok-to-test

tekton-robot commented 1 year ago

@avinal: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/tektoncd/results/pull/440#issuecomment-1524848153): >/ok-to-test > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
avinal commented 1 year ago

443

sayan-biswas commented 1 year ago

/ok-to-test

Roming22 commented 1 year ago

@adambkaplan still needs a /lgtm to be mergeable.

tekton-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, AndrienkoAleksandr, avinal, sayan-biswas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)~~ [adambkaplan,sayan-biswas] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
alan-ghelardi commented 1 year ago

/lgtm

Roming22 commented 1 year ago

/retest