Closed adambkaplan closed 1 year ago
Related to #440
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: sayan-biswas
The full list of commands accepted by this bot can be found here.
The pull request process is described here
The change is good and I'll +1. Maybe we run the e2e test with all overlays? That checks both the overlay configuration for errors and the code to get extra coverage. That'll probably also require we use different configs. I'm suggesting we pursue this as a separate issue. @adambkaplan @sayan-biswas WDYT?
The change is good and I'll +1. Maybe we run the e2e test with all overlays? That checks both the overlay configuration for errors and the code to get extra coverage. That'll probably also require we use different configs. I'm suggesting we pursue this as a separate issue. @adambkaplan @sayan-biswas WDYT?
@enarha I have this PR #470 open, I was waiting for this overlay PR to merged. I'll use the overlays in that.
/lgtm
/test pull-tekton-results-integration-tests
Changes
/kind documentation
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes