tektoncd / results

Long term storage of execution results.
Apache License 2.0
78 stars 74 forks source link

Add overlay for enabling logs #447

Closed adambkaplan closed 1 year ago

adambkaplan commented 1 year ago

Changes

/kind documentation

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

Release Notes

The logs feature with PVC storage can be deployed and tested through a new "logs-local-db" kustomization.
adambkaplan commented 1 year ago

Related to #440

tekton-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sayan-biswas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)~~ [sayan-biswas] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
enarha commented 1 year ago

The change is good and I'll +1. Maybe we run the e2e test with all overlays? That checks both the overlay configuration for errors and the code to get extra coverage. That'll probably also require we use different configs. I'm suggesting we pursue this as a separate issue. @adambkaplan @sayan-biswas WDYT?

sayan-biswas commented 1 year ago

The change is good and I'll +1. Maybe we run the e2e test with all overlays? That checks both the overlay configuration for errors and the code to get extra coverage. That'll probably also require we use different configs. I'm suggesting we pursue this as a separate issue. @adambkaplan @sayan-biswas WDYT?

@enarha I have this PR #470 open, I was waiting for this overlay PR to merged. I'll use the overlays in that.

enarha commented 1 year ago

/lgtm

sayan-biswas commented 1 year ago

/test pull-tekton-results-integration-tests