khrm commented 1 year ago

Changes

Added annotations to support command integration with tkn.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

[ ] Has Docs included if any changes are user facing
[ ] Has Tests included if any functionality added or changed
[x] Tested your changes locally (if this is a code change)
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including functionality, content, code)
[x] Has a kind label. You can add a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[x] Release notes block below has been updated with any user-facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
[ ] Release notes contain the string "action required" if the change requires additional action from users switching to the new release

Release Notes

tkn-results: add annotations so the cli can be run as tkn plugin.

khrm commented 1 year ago

/release-note-none

tekton-robot commented 1 year ago

@khrm: you can only set the release note label to release-note-none if the release-note block in the PR body text is empty or "none".

In response to [this](https://github.com/tektoncd/results/pull/457#issuecomment-1538387147): >/release-note-none Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

khrm commented 1 year ago

/release-note-none

tekton-robot commented 1 year ago

@khrm: you can only set the release note label to release-note-none if the release-note block in the PR body text is empty or "none".

In response to [this](https://github.com/tektoncd/results/pull/457#issuecomment-1538388456): > >/release-note-none > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

adambkaplan commented 1 year ago

Added a release note - this is an important change that users and developers should know about!

adambkaplan commented 1 year ago

We should not block on adding "user friendly" docs. I have filed #475 for this purpose - the docs "meets min" is that the auto-generated docs are synced with code.

xinnjie commented 1 year ago

Any progress?

khrm commented 1 year ago

@adambkaplan We have already integrated with the hub cli. So no new unchartered territory here.

khrm commented 1 year ago

@enarha @sayan-biswas @alan-ghelardi We also want to merge this before the release.

tekton-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, sayan-biswas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)~~ [adambkaplan,sayan-biswas] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

tektoncd / results

[CLI] Add integration support to tkn #457

Changes

Submitter Checklist

Release Notes