tektoncd / results

Long term storage of execution results.
Apache License 2.0
78 stars 74 forks source link

[CLI] Fix the global flag passing from cli arg #461

Closed khrm closed 1 year ago

khrm commented 1 year ago

Changes

Fixes #460

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

Release Notes

khrm commented 1 year ago

/release-note-none

khrm commented 1 year ago

/test pull-tekton-results-integration-tests

enarha commented 1 year ago

I was able to test the change. /approve

tekton-robot commented 1 year ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale with a justification. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

khrm commented 1 year ago

@sayan-biswas @adambkaplan This one also should be merged.

tekton-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enarha, sayan-biswas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)~~ [enarha,sayan-biswas] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sayan-biswas commented 1 year ago

/lgtm