tektoncd / results

Long term storage of execution results.
Apache License 2.0
78 stars 74 forks source link

Add health probes to API server #485

Closed sayan-biswas closed 1 year ago

sayan-biswas commented 1 year ago

Changes

Fixes #280 Fixes #414

This PR adds gRPC and REST health probe endpoints to the API server and configures the liveliness, readiness and startup probe for the API server deployment. Also adds retries for connecting to database to prevent unnecessary pod restarts.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

Release Notes

- api: Add healthz endpoint to enable liveness, readiness, and startup probes for the api-server deployment. Default configuration uses HTTP, but gRPC can also be used.
- api: Poll up to two minutes when establishing the database connection.
tekton-robot commented 1 year ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

sayan-biswas commented 1 year ago

/kind feature

sayan-biswas commented 1 year ago

/ok-to-test

adambkaplan commented 1 year ago

/approve

Accepting as a feature.

tekton-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)~~ [adambkaplan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
adambkaplan commented 1 year ago

Proposing updated release note:

- api: Add healthz endpoint to enable liveness, readiness, and startup probes for the apiserver deployment.
- api: Poll up to two minutes when establishing the database connection.
enarha commented 1 year ago

The change is LGTM, but lets give a chance to other people to review.

alan-ghelardi commented 1 year ago

/lgtm

enarha commented 1 year ago

/test pull-tekton-results-integration-tests