Closed sayan-biswas closed 1 year ago
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
/kind feature
/ok-to-test
/approve
Accepting as a feature.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: adambkaplan
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Proposing updated release note:
- api: Add healthz endpoint to enable liveness, readiness, and startup probes for the apiserver deployment.
- api: Poll up to two minutes when establishing the database connection.
The change is LGTM, but lets give a chance to other people to review.
/lgtm
/test pull-tekton-results-integration-tests
Changes
Fixes #280 Fixes #414
This PR adds gRPC and REST health probe endpoints to the API server and configures the liveliness, readiness and startup probe for the API server deployment. Also adds retries for connecting to database to prevent unnecessary pod restarts.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes