tektoncd / results

Long term storage of execution results.
Apache License 2.0
77 stars 74 forks source link

Add ClusterRole aggregation for default user-facing roles #487

Closed khrm closed 1 year ago

khrm commented 1 year ago

Add ClusterRole aggregation for admin, edit and view users. Refer: https://kubernetes.io/docs/reference/access-authn-authz/rbac/#aggregated-clusterroles

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

Release Notes

NONE
khrm commented 1 year ago

Fixes #486

khrm commented 1 year ago

/retest

sayan-biswas commented 1 year ago

/approve

tekton-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sayan-biswas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)~~ [sayan-biswas] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
khrm commented 1 year ago

@enarha Let's merge this before the release.

khrm commented 1 year ago

/retest

khrm commented 1 year ago

@enarha @adambkaplan Can you re-review this and give lgtm if OK?

khrm commented 1 year ago

Can you re-review this and give lgtm if it's alright, @adambkaplan @vdemeester ?

enarha commented 1 year ago

/lgtm