tektoncd / results

Long term storage of execution results.
Apache License 2.0
77 stars 74 forks source link

add suffcient details to unauthorized errors #489

Closed gabemontero closed 1 year ago

gabemontero commented 1 year ago

Changes

Fixes https://github.com/tektoncd/results/issues/488

/kind cleanup

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

Release Notes

Provide more informative error messages when authorization via the impersonation feature fails.

@sayan-biswas FYI

khrm commented 1 year ago

/release-note-none

edit: Didn't realize there's a note mixed with an empty block.

tekton-robot commented 1 year ago

@khrm: you can only set the release note label to release-note-none if the release-note block in the PR body text is empty or "none".

In response to [this](https://github.com/tektoncd/results/pull/489#issuecomment-1568837489): >/release-note-none Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
khrm commented 1 year ago

/approve

tekton-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khrm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)~~ [khrm] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
enarha commented 1 year ago

/lgtm