Closed khrm closed 1 year ago
@khrm: The following test failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
pull-tekton-results-build-tests | 579867d6f88ba1161f8abb1db8bce2f3272d8f75 | link | true | /test pull-tekton-results-build-tests |
Full PR test history. Your PR dashboard.
Pull request looks good. But I think we need add .bin folder to .gitignore and fix failing "pull-tekton-results-build-tests" ci check.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: AndrienkoAleksandr, vdemeester
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@khrm ping me if you need any help.
@khrm @adambkaplan I created pr with cherry-picked current pr content + lint checks fixes: https://github.com/tektoncd/results/pull/503
@khrm Can this PR is closed, since #503 already includes thes changes?
Yes, it makes sense to close this. I thought @AndrienkoAleksandr has send commits to this pr.
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes