tektoncd / results

Long term storage of execution results.
Apache License 2.0
78 stars 74 forks source link

Add GolangCI via Makefile + Presubmit.sh #493

Closed khrm closed 1 year ago

khrm commented 1 year ago

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

Release Notes

tekton-robot commented 1 year ago

@khrm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-tekton-results-build-tests 579867d6f88ba1161f8abb1db8bce2f3272d8f75 link true /test pull-tekton-results-build-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
AndrienkoAleksandr commented 1 year ago

Pull request looks good. But I think we need add .bin folder to .gitignore and fix failing "pull-tekton-results-build-tests" ci check.

tekton-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndrienkoAleksandr, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)~~ [vdemeester] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
AndrienkoAleksandr commented 1 year ago

@khrm ping me if you need any help.

AndrienkoAleksandr commented 1 year ago

@khrm @adambkaplan I created pr with cherry-picked current pr content + lint checks fixes: https://github.com/tektoncd/results/pull/503

sayan-biswas commented 1 year ago

@khrm Can this PR is closed, since #503 already includes thes changes?

khrm commented 1 year ago

Yes, it makes sense to close this. I thought @AndrienkoAleksandr has send commits to this pr.