tektoncd / results

Long term storage of execution results.
Apache License 2.0
77 stars 74 forks source link

Make cel2sql generic using View abstraction #495

Open RafaeLeal opened 1 year ago

RafaeLeal commented 1 year ago

Changes

This PR makes the cel2sql package more generic, introducing a new View abstraction. This allows us to decouple what we expose for the Results' API filters and the database structure.

I believe it also makes changes in our database safer since we don't have to think of all kinds of filters that would use each column of the db table. The idea is to make the changes and support in the CEL filters more deliberate.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

Release Notes

Refactor cel2sql into a generic and extensible View abstraction
alan-ghelardi commented 1 year ago

/kind misc

alan-ghelardi commented 1 year ago

@RafaeLeal I left a few comments mostly about style and some parts of the code that I'd prefer to leave as before (tests, for example). You need to rebase the pr and write down release notes.

tekton-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)~~ [adambkaplan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tekton-robot commented 1 year ago

@RafaeLeal: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
tekton-robot commented 1 year ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale with a justification. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.