Add GolangCI via Makefile + Presubmit.sh + golangci lint fixes

[AndrienkoAleksandr]

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

• [ ] Has Docs included if any changes are user facing
• [ ] Has Tests included if any functionality added or changed
• [ ] Tested your changes locally (if this is a code change)
• [ ] Follows the commit message standard
• [ ] Meets the Tekton contributor standards (including functionality, content, code)
• [x] Has a kind label. You can add a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• [x] Release notes block below has been updated with any user-facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
• [x] Release notes contain the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Address potential bugs picked up by the golangci linter. Enable golang lint checks in our CI tests.

[tekton-robot]

Hi @AndrienkoAleksandr. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

[khrm]

/kind cleanup /area testing

[tekton-robot]

@khrm: The label(s) area/testing cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/tektoncd/results/pull/503#issuecomment-1596869801): >/kind cleanup >/area testing Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

[sayan-biswas]

/test pull-tekton-results-build-tests

[sayan-biswas]

/retest-required

[khrm]

/test pull-tekton-results-build-tests

[khrm]

@enarha @sayan-biswas I think we can merge this now. Please give lgtm here.

[khrm]

Yes, the last three commits can be merged in the same.

The first commit from me to enable the GolangCI. And. one for all the fixes that we did to make it work.

@AndrienkoAleksandr

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khrm, sayan-biswas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)~~ [khrm,sayan-biswas] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[AndrienkoAleksandr]

@adambkaplan, @khrm, @sayan-biswas I handled code review feedback, squashed my commits and rebased pr.

[enarha]

The change is LGTM. I'll approve once the test is fixed.

[enarha]

Actually one comment. So now we are running a bunch of linters in CI. Shouldn't we document the steps to run those locally before submitting a PR to eliminate issues called only in CI which is more expensive in terms of resources?

[sayan-biswas]

/test pull-tekton-results-integration-tests

[enarha]

The failing test also fails in main when running locally. And it's failing pretty consistently.

[khrm]

/test pull-tekton-results-integration-tests

[khrm]

Is this failure due to this pr?

[enarha]

Is this failure due to this pr?

I do not think it is. As I mentioned in my previous comment, I'm getting the same failure running the e2e test locally from the main branch.

[khrm]

It seems that issue isn't with results, I think it's with a pr merged in pipelines. Let me fix that.

[sayan-biswas]

/test pull-tekton-results-integration-tests