Closed AndrienkoAleksandr closed 1 year ago
Hi @AndrienkoAleksandr. Thanks for your PR.
I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/kind cleanup /area testing
@khrm: The label(s) area/testing
cannot be applied, because the repository doesn't have them.
/test pull-tekton-results-build-tests
/retest-required
/test pull-tekton-results-build-tests
@enarha @sayan-biswas I think we can merge this now. Please give lgtm here.
Yes, the last three commits can be merged in the same.
The first commit from me to enable the GolangCI. And. one for all the fixes that we did to make it work.
@AndrienkoAleksandr
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: khrm, sayan-biswas
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@adambkaplan, @khrm, @sayan-biswas I handled code review feedback, squashed my commits and rebased pr.
The change is LGTM. I'll approve once the test is fixed.
Actually one comment. So now we are running a bunch of linters in CI. Shouldn't we document the steps to run those locally before submitting a PR to eliminate issues called only in CI which is more expensive in terms of resources?
/test pull-tekton-results-integration-tests
The failing test also fails in main when running locally. And it's failing pretty consistently.
/test pull-tekton-results-integration-tests
Is this failure due to this pr?
Is this failure due to this pr?
I do not think it is. As I mentioned in my previous comment, I'm getting the same failure running the e2e test locally from the main branch.
It seems that issue isn't with results, I think it's with a pr merged in pipelines. Let me fix that.
/test pull-tekton-results-integration-tests
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes