tektoncd / results

Long term storage of execution results.
Apache License 2.0
77 stars 74 forks source link

Add GolangCI via Makefile + Presubmit.sh + golangci lint fixes #503

Closed AndrienkoAleksandr closed 1 year ago

AndrienkoAleksandr commented 1 year ago

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

Release Notes

Address potential bugs picked up by the golangci linter. Enable golang lint checks in our CI tests.
tekton-robot commented 1 year ago

Hi @AndrienkoAleksandr. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
khrm commented 1 year ago

/kind cleanup /area testing

tekton-robot commented 1 year ago

@khrm: The label(s) area/testing cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/tektoncd/results/pull/503#issuecomment-1596869801): >/kind cleanup >/area testing Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
sayan-biswas commented 1 year ago

/test pull-tekton-results-build-tests

sayan-biswas commented 1 year ago

/retest-required

khrm commented 1 year ago

/test pull-tekton-results-build-tests

khrm commented 1 year ago

@enarha @sayan-biswas I think we can merge this now. Please give lgtm here.

khrm commented 1 year ago

Yes, the last three commits can be merged in the same.

The first commit from me to enable the GolangCI. And. one for all the fixes that we did to make it work.

@AndrienkoAleksandr

tekton-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khrm, sayan-biswas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)~~ [khrm,sayan-biswas] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
AndrienkoAleksandr commented 1 year ago

@adambkaplan, @khrm, @sayan-biswas I handled code review feedback, squashed my commits and rebased pr.

enarha commented 1 year ago

The change is LGTM. I'll approve once the test is fixed.

enarha commented 1 year ago

Actually one comment. So now we are running a bunch of linters in CI. Shouldn't we document the steps to run those locally before submitting a PR to eliminate issues called only in CI which is more expensive in terms of resources?

sayan-biswas commented 1 year ago

/test pull-tekton-results-integration-tests

enarha commented 1 year ago

The failing test also fails in main when running locally. And it's failing pretty consistently.

khrm commented 1 year ago

/test pull-tekton-results-integration-tests

khrm commented 1 year ago

Is this failure due to this pr?

enarha commented 1 year ago

Is this failure due to this pr?

I do not think it is. As I mentioned in my previous comment, I'm getting the same failure running the e2e test locally from the main branch.

khrm commented 1 year ago

It seems that issue isn't with results, I think it's with a pr merged in pipelines. Let me fix that.

sayan-biswas commented 1 year ago

/test pull-tekton-results-integration-tests