tektoncd / results

Long term storage of execution results.
Apache License 2.0
77 stars 74 forks source link

Add recovery middleware to gRPC server #505

Closed sayan-biswas closed 1 year ago

sayan-biswas commented 1 year ago

Fixes #504

Changes

Add recovery middleware in the gRPC interceptor chain to prevent termination of the main go routine when server panics due to runtime errors.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

Release Notes

- api: Recovery middleware added to intercept server panics, recover and send Internal Server Error response instead of terminating the server.
sayan-biswas commented 1 year ago

/kind misc

sayan-biswas commented 1 year ago

/test pull-tekton-results-integration-tests

tekton-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)~~ [adambkaplan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
enarha commented 1 year ago

/lgtm

sayan-biswas commented 1 year ago

@enarha Rebased, need lgtm.

enarha commented 1 year ago

/lgtm