sayan-biswas commented 1 year ago

Adds a config option PROMETHEUS_HISTOGRAM to enable prometheus histogram for the gRPC server. This records metrics to calculate request latency distributions.

resolves #510

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

[x] Has Docs included if any changes are user facing
[ ] Has Tests included if any functionality added or changed
[x] Tested your changes locally (if this is a code change)
[x] Follows the commit message standard
[ ] Meets the Tekton contributor standards (including functionality, content, code)
[x] Has a kind label. You can add a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[x] Release notes block below has been updated with any user-facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
[ ] Release notes contain the string "action required" if the change requires additional action from users switching to the new release

Release Notes

api: Config option `PROMETHEUS_HISTOGRAM` added to enable histograms (disabled by default).

enarha commented 1 year ago

/approve Please add /kind label. Personally I'm considering this a feature, but I'm leaving it to you to decide. My only question is if we really need the action required here? With the default option being disabled, users do not strictly require to do anything. They do need to set the configuration option to enable the functionality, but doing nothing changes/breaks nothing.

sayan-biswas commented 1 year ago

@enarha Removed "action required". Added kind label to miscellaneous as this change is not much of a feature, and more of enabling a feature which was already there.

tekton-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, enarha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)~~ [adambkaplan,enarha] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

adambkaplan commented 1 year ago

/kind feature

enarha commented 1 year ago

/lgtm

tektoncd / results

Add option to enable prometheus histogram #511

Submitter Checklist

Release Notes