search

tektoncd / results

Long term storage of execution results.
Apache License 2.0
77 stars 74 forks source link

`exists` filters is missing #516

Open alan-ghelardi opened 1 year ago

alan-ghelardi commented 1 year ago

@avinal and all, I'm thinking of implementing support for the has macro instead of the exists one, because the later takes a predicate, which is harder to translate to SQL at a first glance.

The has macro tests whether a field exists in a message or a key in a map, what seems to cover the use cases. Also, it adresses what @sayan-biswas was trying to do in the example described at https://github.com/tektoncd/results/issues/498, although the root cause of that issue need to be adressed too.

What do you think? I'll have some free space this week and I'm planning to work in a pull request for this case.

alan-ghelardi commented 1 year ago

/assign

avinal commented 1 year ago

@alan-ghelardi as long as it provides the functionality, it should be good. We just have to make sure to document that.

avinal commented 1 year ago

Hey @alan-ghelardi, were you able to make some progress on this one?

avinal commented 9 months ago

It's been long since this issue was opened, I will reassign it to myself.

avinal commented 9 months ago

/assign