Closed xinnjie closed 1 year ago
Hi @xinnjie. Thanks for your PR.
I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/assign @adambkaplan
/ok-to-test
/assign @enarha Hi enarha, would you please take a look?
@xinnjie Thank you for your contribution. I'm taking a look and hopefully I'll be able to finish before EOD.
/cc @vdemeester @khrm @sayan-biswas Would be glad if you take a look.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: avinal, enarha, sayan-biswas
The full list of commands accepted by this bot can be found here.
The pull request process is described here
I think the PR is ready, just a last cleanup, please merge all the commits into one.
Squashed.
Is there any thing we are waiting to merge this pr?
Given @sayan-biswas already spent time on reviewing, lets wait for him to lgtm. IMO this PR has been open for long time and received enough reviews. It's on the bigger side, but it only adds functionality and not changing existing functionality, so it's ready to be merged.
@enarha I have already approved it. Was just checking if we need anyone else to review it. I will add this in tomorrow's workgroup call agenda and get it merged after that.
/lgtm
Changes
Add delete count and duration metrics for TaskRun and PipelineRun. It helps to take a move on https://github.com/tektoncd/results/issues/323
About metrics config:
metrics.taskrun.level
does not provideTaskrunLevelAtTaskrun
option andmetrics.pipelinerun.level
does not providePipelinerunLevelAtPipelinrrun
, because these two options are too atomic for metrics and generate too much metrics./kind feature
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes