tektoncd / results

Long term storage of execution results.
Apache License 2.0
78 stars 74 forks source link

Add delete count and duration metrics for TaskRun and PipelineRun #517

Closed xinnjie closed 1 year ago

xinnjie commented 1 year ago

Changes

Add delete count and duration metrics for TaskRun and PipelineRun. It helps to take a move on https://github.com/tektoncd/results/issues/323

About metrics config:

/kind feature

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

Release Notes

Add delete count and duration metrics for TaskRun and PipelineRun
tekton-robot commented 1 year ago

Hi @xinnjie. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
xinnjie commented 1 year ago

/assign @adambkaplan

enarha commented 1 year ago

/ok-to-test

xinnjie commented 1 year ago

/assign @enarha Hi enarha, would you please take a look?

enarha commented 1 year ago

@xinnjie Thank you for your contribution. I'm taking a look and hopefully I'll be able to finish before EOD.

xinnjie commented 1 year ago

/cc @vdemeester @khrm @sayan-biswas Would be glad if you take a look.

tekton-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avinal, enarha, sayan-biswas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)~~ [enarha,sayan-biswas] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
avinal commented 1 year ago

I think the PR is ready, just a last cleanup, please merge all the commits into one.

xinnjie commented 1 year ago

Squashed.

xinnjie commented 1 year ago

Is there any thing we are waiting to merge this pr?

enarha commented 1 year ago

Given @sayan-biswas already spent time on reviewing, lets wait for him to lgtm. IMO this PR has been open for long time and received enough reviews. It's on the bigger side, but it only adds functionality and not changing existing functionality, so it's ready to be merged.

sayan-biswas commented 1 year ago

@enarha I have already approved it. Was just checking if we need anyone else to review it. I will add this in tomorrow's workgroup call agenda and get it merged after that.

sayan-biswas commented 1 year ago

/lgtm