tektoncd / results

Long term storage of execution results.
Apache License 2.0
78 stars 74 forks source link

Fix file permission mismatch for Postgres statefulset #528

Open xinnjie opened 1 year ago

xinnjie commented 1 year ago

Changes

This fix the issue https://github.com/tektoncd/results/issues/522 Kubelet will modify the ownership and permissions of volume to 1001 which Postgres uses after setting securityContext.fsGroup. This pr will helper users who want to try out Results not encounter file permission issues.

Submitter Checklist

/kind bug These are the criteria that every PR should meet, please check them off as you review them:

Release Notes

tekton-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign alan-ghelardi after the PR has been reviewed. You can assign the PR to them by writing /assign @alan-ghelardi in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tekton-robot commented 1 year ago

Hi @xinnjie. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
xinnjie commented 1 year ago

/cc @avina @enarha

tekton-robot commented 1 year ago

@xinnjie: GitHub didn't allow me to request PR reviews from the following users: avina.

Note that only tektoncd members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/tektoncd/results/pull/528#issuecomment-1636695252): >/cc @avina @enarha Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
xinnjie commented 1 year ago

/release-note-none

tekton-robot commented 1 year ago

@xinnjie: you can only set the release note label to release-note-none if the release-note block in the PR body text is empty or "none".

In response to [this](https://github.com/tektoncd/results/pull/528#issuecomment-1637122975): >/release-note-none Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
sayan-biswas commented 1 year ago

/ok-to-test

xinnjie commented 1 year ago

/release-note-none

tekton-robot commented 1 year ago

@xinnjie: you can only set the release note label to release-note-none if the release-note block in the PR body text is empty or "none".

In response to [this](https://github.com/tektoncd/results/pull/528#issuecomment-1637350497): >/release-note-none Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
xinnjie commented 1 year ago

/release-note-none

tekton-robot commented 1 year ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale with a justification. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

tekton-robot commented 1 year ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten with a justification. Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.